In the module “Booking Calendar” (bookingcalendar) from RM RM for PrestaShop, a guest can perform SQL injection in affected versions if the module is not installed OR if a secret accessible to administrator is stolen.

Summary

  • CVE ID: CVE-2023-46914
  • Published at: 2024-02-06
  • Platform: PrestaShop
  • Product: bookingcalendar
  • Impacted release: <= 2.7.9 (WARNING : Author discontinue support since years - no fix)
  • Product author: RM RM
  • Weakness: CWE-89
  • Severity: critical (9.8)

Description

Foreword : we are forced to tag privilege NONE on the CVSS 3.1 score which make it a critical vulnerability since it will be critical if the module has never been installed OR (if the BOOKINGCALENDAR_ics_export configuration do not exist OR is empty), but keep in mind that for the majority of installations, the gravity is reduced to CVSS 3.1 7.2/10

The script PHP ics_export.php own sensitives SQL calls that can be executed with a trivial http call and exploited to forge a SQL injection.

WARNING : Be warned that older versions own true critical issues (still actively searched and exploited). This module is no longer maintain since years so you should delete it.

CVSS base metrics

  • Attack vector: network
  • Attack complexity: low
  • Privilege required: none
  • User interaction: none
  • Scope: unchanged
  • Confidentiality: high
  • Integrity: high
  • Availability: high

Vector string: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H

Possible malicious usage

  • Obtain admin access
  • Steal/Remove data from the associated PrestaShop
  • Copy/paste data from sensitive tables to FRONT to expose tokens and unlock admins’s ajax scripts
  • Rewrite SMTP settings to hijack emails

Patch from 2.7.9

--- 2.7.9/modules/bookingcalendar/ics_export.php
+++ XXXXX/modules/bookingcalendar/ics_export.php
...
-if (Tools::getIsset('lang') && Configuration::get('BOOKINGCALENDAR_ics_export')==Tools::getValue('id'))
+if (Tools::getIsset('lang') && !Tools::isEmpty('id') && Tools::getValue('id') === Configuration::get('BOOKINGCALENDAR_ics_export'))
...
-	  $req.=' and idp='.Tools::getValue('id_product');
+	  $req.=' and idp='.(int) Tools::getValue('id_product');

--- 2.7.9/modules/bookingcalendar/bookingcalendar.php
+++ XXXXX/modules/bookingcalendar/bookingcalendar.php
...
-$row = Db::getInstance()->getRow('select ecart from `'._DB_PREFIX_.'a_booking_plus` where debut=\''.$debut.'\' and id_product=\''.$id_product.'\' ');
+$row = Db::getInstance()->getRow('select ecart from `'._DB_PREFIX_.'a_booking_plus` where debut=\''.pSQL($debut).'\' and id_product=\''.(int) $id_product.'\' ');
...

Patch from 2.5.6

--- 2.5.6/modules/bookingcalendar/controllers/front/list.php
+++ XXXXX/modules/bookingcalendar/controllers/front/list.php
...
-		$enter=Tools::getValue('enter');
+		$enter=pSQL(Tools::getValue('enter'));
...
-			$row = Db::getInstance()->getRow('select * from `'._DB_PREFIX_.'a_booking_plus` where id_product=\''.(int)Tools::getValue('id_product').'\' and debut=\''.Tools::getValue('enter').' 00:00:00\'');
+			$row = Db::getInstance()->getRow('select * from `'._DB_PREFIX_.'a_booking_plus` where id_product=\''.(int)Tools::getValue('id_product').'\' and debut=\''.pSQL(Tools::getValue('enter')).' 00:00:00\'');
...

--- 2.5.6/modules/bookingcalendar/controllers/front/list1_7.php
+++ XXXXX/modules/bookingcalendar/controllers/front/list1_7.php
...
-		$enter=Tools::getValue('enter');
+		$enter=pSQL(Tools::getValue('enter'));
...
-			$row = Db::getInstance()->getRow('select * from `'._DB_PREFIX_.'a_booking_plus` where id_product=\''.(int)Tools::getValue('id_product').'\' and debut=\''.Tools::getValue('enter').' 00:00:00\'');
+			$row = Db::getInstance()->getRow('select * from `'._DB_PREFIX_.'a_booking_plus` where id_product=\''.(int)Tools::getValue('id_product').'\' and debut=\''.pSQL(Tools::getValue('enter')).' 00:00:00\'');
...

Other recommendations

  • It’s recommended to delete the module bookingcalendar.
  • To help improve the security of your PrestaShop installation, we recommend upgrading to the latest version. One of the benefits of upgrading is that it will disable the use of multiquery executions (separated by semicolons). However, please be aware that this will not protect your shop against SQL injection attacks that use the UNION clause to steal data. Additionally, it’s important to note that PrestaShop includes a function called pSQL, which includes a strip_tags function. This helps protect your shop against Stored XSS (also known as XSS T2) of Category 1. If a pSQL function is missing, it could potentially expose your project to critical Stored XSS vulnerabilities due to edge cases. Therefore, it’s crucial to ensure that all relevant functions are properly implemented and used consistently throughout your project.
  • Change the default database prefix ps_ with a new longer, arbitrary prefix. Nevertheless, be warned that this is useless against blackhats with DBA senior skill because of a design vulnerability in DBMS
  • Activate OWASP 942’s rules on your WAF (Web application firewall), be warned that you will probably break your backoffice and you will need to pre-configure some bypasses against this set of rules.

Timeline

Date Action
2023-10-24 Issue discovered during a code review by TouchWeb.fr
2023-10-24 Contact PrestaShop Addons security Team to confirm version scope
2023-10-24 PrestaShop Addons security Team confirms version scope
2024-02-05 Received CVE ID
2024-02-06 Publish this security advisory