IMPORTANT NOTICE: DO NOT REPORT VULNERABILITIES SOLELY TO THE AUTHOR OR MARKETPLACE.
We urge you to report any vulnerabilities directly to us. Our mission is to ensure the safety and security of the PrestaShop ecosystem. Unfortunately, many module developers may not always recognize or acknowledge the vulnerabilities in their code, whether due to lack of awareness, or inability to properly evaluate the associated risk, or other reasons.
Given the rise in professional cybercrime networks actively seeking out these vulnerabilities, it's crucial that any potential threats are promptly addressed and the community is informed. The most effective method to do this is by publishing a CVE, like the one provided below.
Should you discover any vulnerabilities, please report them to us at: report[@]security-presta.org or visit https://security-presta.org for more information.
Every vulnerability report helps make the community more secure, and we are profoundly grateful for any information shared with us.
[CVE-2023-27845] Improper neutralization of a SQL parameter in KerAwen Omnichannel Stocks module for PrestaShop
In the module “KerAwen Omnichannel Stocks” (kerawen_ocs) for PrestaShop, an anonymous user can perform SQL injection before 1.4.1. Release 1.4.1 fixed this security issue.
Summary
- CVE ID: CVE-2023-27845
- Published at: 2023-07-06
- Advisory source: Friends-Of-Presta.org
- Platform: PrestaShop
- Product: kerawen_ocs
- Impacted release: < 1.4.1
- Product author: KerAwen
- Weakness: CWE-89
- Severity: critical (9.8)
Description
Up to 1.3.7.1, multiple sensitive SQL calls in class KerawenHelper::setCartOperationInfo()
and KerawenHelper::resetCheckoutSessionData()
can be executed with a trivial http call and exploited to forge a blind SQL injection throught the POST or GET submitted “ocs_id_cart” or “ocs_checkout_session_data” variable.
CVSS base metrics
- Attack vector: network
- Attack complexity: low
- Privilege required: none
- User interaction: none
- Scope: unchanged
- Confidentiality: high
- Integrity: high
- Availability: high
Vector string: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H
Possible malicious usage
- Obtain admin access
- Remove data from the associated PrestaShop
- Copy/paste data from sensitive tables to FRONT to exposed tokens and unlock admins’ ajax scripts
- Rewrite SMTP settings to hijack emails
Patch
Sample of patch. We recommend to upgrade this module to fix all sensitive SQL calls.
--- a/modules/kerawen_ocs/classes/KerawenHelper.php
+++ b/modules/kerawen_ocs/classes/KerawenHelper.php
@@ -3622,23 +3622,23 @@ class KerawenHelper
public static function setCartOperationInfo($id_cart, $data)
{
$current_date_time = date('Y-m-d H:i:s');
- $temp_sql = 'SELECT * FROM `' . _DB_PREFIX_ . self::$_TABLE_NAME_CART_OPERATION_INFO . '` WHERE id_cart = '.pSQL($id_cart);
+ $temp_sql = 'SELECT * FROM `' . _DB_PREFIX_ . self::$_TABLE_NAME_CART_OPERATION_INFO . '` WHERE id_cart = '. (int) $id_cart;
$temp_result = Db::getInstance()->executeS($temp_sql);
if (!empty($temp_result) && count($temp_result) >0) {
// update
$upd_sql = 'UPDATE `' . _DB_PREFIX_ . self::$_TABLE_NAME_CART_OPERATION_INFO . '` SET `data`= "' . pSQL($data) . '" ,`date_update`="' . pSQL($current_date_time) . '"
- WHERE id_cart =' . pSQL($id_cart) . ';';
+ WHERE id_cart =' . (int) $id_cart . ';';
Db::getInstance()->execute($upd_sql);
} else {
// insert
- $insert_sql_debug = 'INSERT INTO `' . _DB_PREFIX_ . self::$_TABLE_NAME_CART_OPERATION_INFO . '` ( `id_cart`, `data`, `date_add`, `date_update`) VALUES ( '.pSQL($id_cart).', "' . pSQL($data) . '","' . pSQL($current_date_time) . '","' . pSQL($current_date_time) . '");';
+ $insert_sql_debug = 'INSERT INTO `' . _DB_PREFIX_ . self::$_TABLE_NAME_CART_OPERATION_INFO . '` ( `id_cart`, `data`, `date_add`, `date_update`) VALUES ( '. (int) $id_cart.', "' . pSQL($data) . '","' . pSQL($current_date_time) . '","' . pSQL($current_date_time) . '");';
Db::getInstance()->execute($insert_sql_debug);
}
}
public static function getCartOperationInfo($id_cart)
{
- $temp_sql = 'SELECT * FROM `' . _DB_PREFIX_ . self::$_TABLE_NAME_CART_OPERATION_INFO . '` WHERE id_cart = '.pSQL($id_cart);
+ $temp_sql = 'SELECT * FROM `' . _DB_PREFIX_ . self::$_TABLE_NAME_CART_OPERATION_INFO . '` WHERE id_cart = '. (int) $id_cart;
$temp_result = Db::getInstance()->executeS($temp_sql);
if (!empty($temp_result) && count($temp_result) >0) {
return $temp_result[0]['data'];
Other recommandations
-
- To help improve the security of your PrestaShop installation, we recommend upgrading to the latest version. One of the benefits of upgrading is that it will disable the use of multiquery executions (separated by semicolons). However, please be aware that this will not protect your shop against SQL injection attacks that use the UNION clause to steal data. Additionally, it’s important to note that PrestaShop includes a function called pSQL, which includes a strip_tags function. This helps protect your shop against Stored XSS (also known as XSS T2) of Category 1. If a pSQL function is missing, it could potentially expose your project to critical Stored XSS vulnerabilities due to edge cases. Therefore, it’s crucial to ensure that all relevant functions are properly implemented and used consistently throughout your project.
- Change the default database prefix
ps_
by a new longer arbitrary prefix. Nevertheless, be warned that this is useless against blackhats with DBA senior skills because of a design vulnerability in DBMS - Activate OWASP 942’s rules on your WAF (Web application firewall), be warned that you will probably break your backoffice and you will need to pre-configure some bypasses against these set of rules.
Timeline
Date | Action |
---|---|
2022-11-23 | Vunlnerability found during a audit by 202 ecommerce |
2022-11-23 | Contact the author |
2023-02-12 | Request a CVE ID |
2023-02 | Fix published by the author |
2023-03-07 | New vunerability found |
2023-05 | Fix published by the author |
2023-07-06 | Publication of this advisory |
Links
DISCLAIMER: The French Association Friends Of Presta (FOP) acts as an intermediary to help hosting this advisory. While we strive to ensure the information and advice provided are accurate, FOP cannot be held liable for any consequences arising from reported vulnerabilities or any subsequent actions taken.
This advisory and patch is licensed under CC BY-SA 4.0