IMPORTANT NOTICE: DO NOT REPORT VULNERABILITIES SOLELY TO THE AUTHOR OR MARKETPLACE.
We urge you to report any vulnerabilities directly to us. Our mission is to ensure the safety and security of the PrestaShop ecosystem. Unfortunately, many module developers may not always recognize or acknowledge the vulnerabilities in their code, whether due to lack of awareness, or inability to properly evaluate the associated risk, or other reasons.
Given the rise in professional cybercrime networks actively seeking out these vulnerabilities, it's crucial that any potential threats are promptly addressed and the community is informed. The most effective method to do this is by publishing a CVE, like the one provided below.
Should you discover any vulnerabilities, please report them to us at: report[@]security-presta.org or visit https://security-presta.org for more information.
Every vulnerability report helps make the community more secure, and we are profoundly grateful for any information shared with us.
[CVE-2023-26858] Improper neutralization of SQL parameter in faqs module for PrestaShop
In the module “Frequently Asked Questions (FAQ) page” (faqs) for PrestaShop, an attacker can perform SQL injection up to 3.1.5. Release 3.1.6 fixed this security issue.
Summary
- CVE ID: CVE-2023-26858
- Published at: 2023-03-28
- Advisory source: Friends-Of-Presta.org
- Platform: PrestaShop
- Product: faqs
- Impacted release: < 3.1.6
- Product author: MyPrestaModules
- Weakness: CWE-89
- Severity: critical (9.8)
Description
Before 3.1.6, a sensitive SQL call in class faqsPost::getIdFaqsAssociatedToProductCategories() can be executed with a trivial http call and exploited to forge a blind SQL injection through the POST or GET submitted variable id_category.
CVSS base metrics
- Attack vector: network
- Attack complexity: low
- Privilege required: none
- User interaction: none
- Scope: unchanged
- Confidentiality: high
- Integrity: high
- Availability: high
Vector string: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H
Possible malicious usage
- Technical and personal data leaks
- Obtain admin access
- Remove all data of the linked PrestaShop
- Display sensitives tables to front-office to unlock potential admin’s ajax scripts of modules protected by token on the ecosystem
Proof of concept
curl -v -X POST -d 'controller=category&id_category=1);SELECT+SLEEP(25);--' 'https://domain.tld'
Patch
--- a/faqs/classes/faqsPost.php
+++ b/faqs/classes/faqsPost.php
@@ -480,7 +480,7 @@ class faqsPost extends ObjectModel
*/
public static function getIdFaqsAssociatedToProductCategories($productCategoriesIds)
{
- $productCategoriesIds = implode(',', $productCategoriesIds);
+ $productCategoriesIds = implode(',', array_map('intval', explode(',',$productCategoriesIds)));
$sql = 'SELECT ac.id_faq
FROM ' . _DB_PREFIX_ . 'faq_association_category ac
Other recommendations
- It’s recommended to upgrade the module beyond 3.1.6.
- Upgrade PrestaShop to the latest version to disable multiquery executions (separated by “;”) - be warned that this functionality WILL NOT protect your SHOP against injection SQL which uses the UNION clause to steal data.
- Change the default database prefix ps_ by a new longer arbitrary prefix. Nevertheless, be warned that this is useless against blackhats with DBA senior skill because of a design vulnerability in DBMS
- Activate OWASP 942’s rules on your WAF (Web application firewall), be warned that you will probably break your backoffice and you will need to pre-configure some bypasses against these set of rules.
Timeline
| Date | Action |
|---|---|
| 2022-12-02 | Contact the author |
| 2022-12-12 | Fix published on addons PrestaShop marketplace by the author |
| 2023-02-12 | Request a CVE ID |
| 2023-03-17 | Propose a delay to PrestaShop addons security team before disclosing the CVE |
| 2023-03-28 | Publish this security advisory |
Links
DISCLAIMER: The French Association Friends Of Presta (FOP) acts as an intermediary to help hosting this advisory. While we strive to ensure the information and advice provided are accurate, FOP cannot be held liable for any consequences arising from reported vulnerabilities or any subsequent actions taken.