IMPORTANT NOTICE: DO NOT REPORT VULNERABILITIES SOLELY TO THE AUTHOR OR MARKETPLACE.
We urge you to report any vulnerabilities directly to us. Our mission is to ensure the safety and security of the PrestaShop ecosystem. Unfortunately, many module developers may not always recognize or acknowledge the vulnerabilities in their code, whether due to lack of awareness, or inability to properly evaluate the associated risk, or other reasons.
Given the rise in professional cybercrime networks actively seeking out these vulnerabilities, it's crucial that any potential threats are promptly addressed and the community is informed. The most effective method to do this is by publishing a CVE, like the one provided below.
Should you discover any vulnerabilities, please report them to us at: report[@]security-presta.org or visit https://security-presta.org for more information.
Every vulnerability report helps make the community more secure, and we are profoundly grateful for any information shared with us.
[CVE-2023-30149] Improper neutralization of SQL parameter in the City Autocomplete (cityautocomplete) module from ebewe.net for PrestaShop
SQL injection vulnerability in the City Autocomplete (cityautocomplete) module from ebewe.net for PrestaShop, prior to version 1.8.12 (for PrestaShop version 1.5/1.6) or prior to 2.0.3 (for PrestaShop version 1.7), allows remote attackers to execute arbitrary SQL commands via the type, input_name. or q parameter in the autocompletion.php front controller.
Summary
- CVE ID: CVE-2023-30149
- Published at: 2023-06-01
- Advisory source: Friends-Of-Presta
- Vendor: PrestaShop
- Product: cityautocomplete
- Impacted release: PS 1.5/1.6 : < 1.8.12 (fixed in version 1.8.12), PS 1.7 : < 2.0.3 (fixed in version 2.0.3)
- Product author: ebewe.net
- Weakness: CWE-89
- Severity: critical (9.8)
Description
An HTTP request can be manipulated using type or q GET parameters, in the /module/cityautocomplete/autocompletion FrontController endpoint, enabling a remote attacker to perform an SQL injection. The issue is fixed in version 1.8.12 and 2.0.3, published on October, 2022.
Note : The version 2.X also includes an additional parameter input_name. See patch below for more details.
WARNING : This exploit is actively used to deploy webskimmer to massively steal credit cards.
This exploit uses a PrestaShop front controller and most attackers can conceal the module controller’s path during the exploit so you will never know within your conventional frontend logs that it exploits this vulnerability. You will only see “POST /” inside your conventional frontend logs. Activating the AuditEngine of mod_security (or similar) is the only way to get data to confirm this exploit.
CVSS base metrics
- Attack vector: network
- Attack complexity: low
- Privilege required: none
- User interaction: none
- Scope: unchanged
- Confidentiality: high
- Integrity: high
- Availability: high
Vector string: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H
Possible malicious usage
- Obtain admin access
- Remove data from the associated PrestaShop
- Copy/paste data from sensitive tables to FRONT to exposed tokens and unlock admins’ ajax scripts
- Rewrite SMTP settings to hijack emails
Proof of concept
https://example.test/module/cityautocomplete/autocompletion?q=39000&type=1;select(0x73656C65637420736C656570283432293B)INTO@a;prepare`b`from@a;execute`b`;--&input_name=postcode&limit=10
Patch
For versions > 2.0.0 and < 2.0.3:
--- a/controllers/front/autocompletion.php
+++ b/controllers/front/autocompletion.php
@@ -43,13 +43,23 @@ class CityAutocompleteAutocompletionModuleFrontController extends ModuleFrontCon
&& Tools::getIsset('limit')) {
$id_lang = Context::getContext()->language->id;
+ $type = Tools::getValue('type');
+ if (!in_array($type, array('postcode', 'city'))) {
+ die(Tools::jsonEncode(array()));
+ }
+
+ $inputName = Tools::getValue('input_name');
+ if (!in_array($inputName, array('postcode', 'city'))) {
+ die(Tools::jsonEncode(array()));
+ }
+
$sql = 'SELECT ca.postcode, ca.city, ca.iso_code, c.id_country, cl.name,
- "'.(string)Tools::getValue('input_name').'" as input_name
+ `'.bqSQL($inputName).'` as input_name
FROM `'._DB_PREFIX_.'cityautocomplete` ca
LEFT JOIN `'._DB_PREFIX_.'country` c ON (ca.iso_code = c.iso_code)
LEFT JOIN `'._DB_PREFIX_.'country_lang` cl ON (c.id_country = cl.id_country)
WHERE id_lang='.(int)$id_lang.'
- AND '.(string)Tools::getValue('type').' LIKE "'.(string)Tools::getValue('q').'%"
+ AND `'.bqSQL($type).'` LIKE "'.pSQL(Tools::getValue('q')).'%"
LIMIT 0, '.(int)Tools::getValue('limit');
$result = Db::getInstance()->ExecuteS($sql);
For versions < 1.8.12:
--- a/controllers/front/autocompletion.php
+++ b/controllers/front/autocompletion.php
@@ -39,13 +39,18 @@ class CityAutocompleteAutocompletionModuleFrontController extends ModuleFrontCon
{
parent::initContent();
if (Tools::getIsset('q') && Tools::getIsset('type') && Tools::getIsset('limit')) {
+
+ $type = Tools::getValue('type');
+ if (!in_array($type, array('postcode', 'city'))) {
+ die(Tools::jsonEncode(array()));
+ }
+
$id_lang = Context::getContext()->language->id;
$sql = 'SELECT ca.postcode, ca.city, ca.iso_code, c.id_country, cl.name
FROM `'._DB_PREFIX_.'cityautocomplete` ca
LEFT JOIN `'._DB_PREFIX_.'country` c ON (ca.iso_code = c.iso_code)
LEFT JOIN `'._DB_PREFIX_.'country_lang` cl ON (c.id_country = cl.id_country)
WHERE id_lang='.(int)$id_lang.'
- AND '.Tools::getValue('type').' LIKE "'.Tools::getValue('q').'%"
+ AND `'.bqSQL($type).'` LIKE "'.pSQL(Tools::getValue('q')).'%"
LIMIT 0, '.(int)Tools::getValue('limit');
$result = Db::getInstance()->ExecuteS($sql);
die(Tools::jsonEncode($result));
Other recommendations
- Upgrade the module to the most recent version
- To help improve the security of your PrestaShop installation, we recommend upgrading to the latest version. One of the benefits of upgrading is that it will disable the use of multiquery executions (separated by semicolons). However, please be aware that this will not protect your shop against SQL injection attacks that use the UNION clause to steal data. Additionally, it’s important to note that PrestaShop includes a function called pSQL, which includes a strip_tags function. This helps protect your shop against Stored XSS (also known as XSS T2) of Category 1. If a pSQL function is missing, it could potentially expose your project to critical Stored XSS vulnerabilities due to edge cases. Therefore, it’s crucial to ensure that all relevant functions are properly implemented and used consistently throughout your project.
- Change the default database prefix
ps_by a new longer arbitrary prefix. Nevertheless, be warned that this is useless against blackhats with DBA senior skills because of a design vulnerability in DBMS - Activate OWASP 942’s rules on your WAF (Web application firewall), be warned that you will probably break your backoffice and you will need to pre-configure some bypasses against these set of rules.
Timeline
| Date | Action |
|---|---|
| 2022-09-08 | Discovery of the vulnerability by Profileo |
| 2022-09-10 | Security issue reported to the author, using addons support platform |
| 2022-09-17 | Issue confirmed by the author |
| 2022-10-07 | Release of version 1.8.12 fixing the issue |
| 2023-03-25 | Request for additional details concerning impacted versions |
| 2023-04-02 | Update the patch to adapt to version 2.X |
| 2023-04-13 | Get additional details concerning impacted versions |
| 2023-06-01 | Publication of the security advisory |
Links
DISCLAIMER: The French Association Friends Of Presta (FOP) acts as an intermediary to help hosting this advisory. While we strive to ensure the information and advice provided are accurate, FOP cannot be held liable for any consequences arising from reported vulnerabilities or any subsequent actions taken.
This advisory and patch is licensed under CC BY-SA 4.0
