IMPORTANT NOTICE: DO NOT REPORT VULNERABILITIES SOLELY TO THE AUTHOR OR MARKETPLACE.
We urge you to report any vulnerabilities directly to us. Our mission is to ensure the safety and security of the PrestaShop ecosystem. Unfortunately, many module developers may not always recognize or acknowledge the vulnerabilities in their code, whether due to lack of awareness, or inability to properly evaluate the associated risk, or other reasons.
Given the rise in professional cybercrime networks actively seeking out these vulnerabilities, it's crucial that any potential threats are promptly addressed and the community is informed. The most effective method to do this is by publishing a CVE, like the one provided below.
Should you discover any vulnerabilities, please report them to us at: report[@]security-presta.org or visit https://security-presta.org for more information.
Every vulnerability report helps make the community more secure, and we are profoundly grateful for any information shared with us.
[CVE-2022-40839] Improper neutralization of SQL parameter in NdkAdvancedCustomizationFields module for PrestaShop
In NdkAdvancedCustomizationFields module for PrestaShop before 4.1.7, an anonymous user can perform a SQL injection in affected versions. 4.1.7 fixed the vulnerability.
Summary
- CVE ID: CVE-2022-40839
- Published at: 2022-11-01
- Advisory source: @daaaalllii
- Platform: PrestaShop
- Product: ndk_advanced_custom_fields
- Impacted release: <=4.1.6 (4.1.7 fixed the vulnerability)
- Product author: ndk design
- Weakness: CWE-89
- Severity: critical (9.8)
Description
In the NdkAdvancedCustomizationFields module for PrestaShop up to version 4.1.6, a sensitive SQL call in the NdkCf class can be executed via a trivial HTTP call. This vulnerability can be exploited to initiate a blind SQL injection, for instance, through the POST or GET submitted height and width variables.
CVSS base metrics
- Attack vector: network
- Attack complexity: low
- Privilege required: none
- User interaction: none
- Scope: unchanged
- Confidentiality: high
- Integrity: high
- Availability: high
Vector string: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H
Possible malicious usage
- Obtain admin access
- Remove data from the associated PrestaShop
- Copy/paste data from sensitive tables to FRONT to expose tokens and unlock admins’ ajax scripts
- Rewrite SMTP settings to hijack emails
Proof of concept
Parameters: height,width
Payload: 1’ AND (SELECT 6330 FROM (SELECT(SLEEP(5)))pQfS) AND ‘dpZV’=’dpZV
Exploit:
http://localhost/modules/ndk_advanced_custom_fields/front_ajax.php?action=getRangePrice&group=19&width=1' AND (SELECT 6330 FROM (SELECT(SLEEP(5)))pQfS) AND 'dpZV'='dpZV&height=1
Patch
Prestashop provide a built in function for sanitising strings to be used in SQL queries called pSQL. This is the quick fix in situations like this but one must be sure to surround the parameter with quotes or the query will still be vulnerable to SQLi
For the function getDimensionPrice, the two problematics parameters, width and height were put in pSQL functions to be sanitised as shown :
--- a/models/ndkCf.php
+++ b/models/ndkCf.php
@@ -698,589 +1369,1100 @@ class NdkCf extends ObjectModel
public static function getDimensionPrice($field, $width, $height)
{
...
//on cherche la valeur exacte
$result = Db::getInstance(_PS_USE_SQL_SLAVE_)->getRow(
'SELECT price FROM '._DB_PREFIX_.'ndk_customization_field_csv
WHERE id_ndk_customization_field = '.(int)$field->id.'
- AND width = \''.$width.'\' AND height = \''.$height.'\'');
+ AND width = \''.pSQL($width).'\' AND height = \''.pSQL($height).'\'');
$item_price = str_replace(',', '.', $result['price']);
return $item_price;
}
else
{
$sql = 'SELECT price FROM '._DB_PREFIX_.'ndk_customization_field_csv
WHERE id_ndk_customization_field = '.(int)$field->id.'
- ORDER BY ABS(width-'.$width.') ASC, ABS(height-'.$height.') ASC LIMIT 1';
+ AND width >= '.(float)$width.' AND height >= '.(float)$height.' LIMIT 1';
$result = Db::getInstance(_PS_USE_SQL_SLAVE_)->executeS($sql);
if($result)
But the function getRangePrice is still the same as the function wasn’t used :
--- a/models/ndkCf.php
+++ b/models/ndkCf.php
@@ -698,589 +1369,1100 @@ class NdkCf extends ObjectModel
public static function getRangePrice($field, $width, $height)
{
$results = Db::getInstance(_PS_USE_SQL_SLAVE_)->executeS(
'SELECT * FROM '._DB_PREFIX_.'ndk_customization_field_csv
WHERE id_ndk_customization_field = '.(int)$field->id.'
- AND width >= '.$width.' AND height >= '.$height.'
- ORDER BY width ASC');
+ AND width >= '.(float)$width.' AND height >= '.(float)$height.'
+ ORDER BY width ASC');
Other recommendations
- It’s highly recommended to upgrade the module to the latest version or to delete the module if unused.
-
- To help improve the security of your PrestaShop installation, we recommend upgrading to the latest version. One of the benefits of upgrading is that it will disable the use of multiquery executions (separated by semicolons). However, please be aware that this will not protect your shop against SQL injection attacks that use the UNION clause to steal data. Additionally, it’s important to note that PrestaShop includes a function called pSQL, which includes a strip_tags function. This helps protect your shop against Stored XSS (also known as XSS T2) of Category 1. If a pSQL function is missing, it could potentially expose your project to critical Stored XSS vulnerabilities due to edge cases. Therefore, it’s crucial to ensure that all relevant functions are properly implemented and used consistently throughout your project.
- Change the default database prefix
ps_by a new longer arbitrary prefix. Nevertheless, be warned that this is useless against blackhats with DBA senior skills because of a design vulnerability in DBMS - Activate OWASP 942’s rules on your WAF (Web application firewall), be warned that you will probably break your backoffice and you will need to pre-configure some bypasses against these set of rules.
Timeline
| Date | Action |
|---|---|
| 01-11-2022 | GitHub Poc |
| 26-07-2023 | Publish this advisory on security |
Links
DISCLAIMER: The French Association Friends Of Presta (FOP) acts as an intermediary to help hosting this advisory. While we strive to ensure the information and advice provided are accurate, FOP cannot be held liable for any consequences arising from reported vulnerabilities or any subsequent actions taken.
This advisory and patch is licensed under CC BY-SA 4.0
